Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

index.html does not validate #997

Closed
moloko opened this issue Mar 14, 2016 · 5 comments
Closed

index.html does not validate #997

moloko opened this issue Mar 14, 2016 · 5 comments
Assignees
@moloko
Labels
bug
Milestone
v2.0.8

Comments

@moloko
Copy link
Contributor

moloko commented Mar 14, 2016

if validated using https://validator.w3.org/, two errors and a smattering of warnings are shown
@moloko moloko added the bug label Mar 14, 2016
@moloko moloko modified the milestones: v2.0.9, v2.0.8 Mar 14, 2016
@moloko moloko self-assigned this Mar 14, 2016
@oliverfoster
Copy link
Member

What are we validating against? This has to be part html4, part html5, part iOS + IE hacks.

@moloko
Copy link
Contributor Author

moloko commented Mar 14, 2016

I'm just chucking src/index.html in to the above validator, nothing more...

@moloko
Copy link
Contributor Author

moloko commented Mar 14, 2016

for example it highlighted that the accessibility button had role='button' which is obviously not needed - assume it was just from when we used to use anchor tags for things like this

@oliverfoster
Copy link
Member

Yea, that's fair.

@moloko
Copy link
Contributor Author

moloko commented Mar 14, 2016

see #998

I'll also need to do the files in contrib-spoor; will do that once this is accepted

moloko added a commit that referenced this issue Mar 15, 2016
@moloko
Merge pull request #998 from adaptlearning/issue/#997
117df58 
updates to allow for better validation
moloko added a commit to adaptlearning/adapt-contrib-spoor that referenced this issue Mar 15, 2016
@moloko
updates to allow for better validation (see adaptlearning/adapt_frame…
85e1d2f 
…work#997)

remove the 'encoding' meta tag as it is not valid
remove 'language' attribute from <script> tags, these are not needed
remove 'role' attribute from button tag, it is not needed
@moloko moloko mentioned this issue Mar 15, 2016
Merged
@moloko moloko closed this as completed Mar 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@moloko moloko

Labels
bug
Projects
None yet
Milestone
v2.0.8
Development

No branches or pull requests
2 participants
@moloko @oliverfoster