more segregation of copy & watch task #1000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
| '!<%= sourcedir %>core/js/libraries/json2.js', | ||
| '!<%= sourcedir %>core/js/libraries/consoles.js', | ||
| '!<%= sourcedir %>core/js/libraries/jquery.js', | ||
| '!<%= sourcedir %>core/js/libraries/jquery.v2.js' |
There was a problem hiding this comment.
Do we want to use a glob here? (i.e. like libraries/*) -- why do we only copy some?
There was a problem hiding this comment.
We need to make sure that after making change to these specific files should not trigger a javascript:dev task because we are just intended to copy them directly into the build folder.
I haven't used glob here because there are few other libraries available (e.g. backbone.js, etc..) which needs to be watched for there changes as they becomes a part of adapt.min.js.
|
+1 |
2 similar comments
|
+1 |
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.