Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue-1233: added grunt diff #1235

Merged
merged 1 commit into from
Mar 7, 2017
Merged

issue-1233: added grunt diff #1235

merged 1 commit into from
Mar 7, 2017

Conversation

oliverfoster
Copy link
Member

@oliverfoster oliverfoster commented Sep 8, 2016

This task is a dev rebuild, checking if files are newer and recompiling if necessary.
It doesn't do a watch or a clean.

Only performs a check on LESS, Handlebars and JavaScript

@aniketdharia
Copy link
Member

👍

@lc-thomasberger
Copy link
Member

Nice one! Would be good to have a Version of this that watches for json and js/less. If it listens to json changes, you get a really fast compilation time when adding content to the course.

@oliverfoster
Copy link
Member Author

oliverfoster commented Oct 4, 2016

+1 @lc-thomasberger yea, should be pretty easy - following the same pattern.

@oliverfoster
Copy link
Member Author

oliverfoster commented Nov 8, 2016

@lc-thomasberger it takes almost as much time to check if the json is newer as it does to rebuild it and the extra config needed is quite big. can we leave the json out for the moment?

@sarveshwar-gavhane
Copy link
Contributor

@oliverfoster it would be the good enhancement for newer file checking and last modified source files, when will this changes are pushed into the framework.

@oliverfoster
Copy link
Member Author

@sarveshwar-gavhane i need to get the 3 +1s on it

@sarveshwar-gavhane
Copy link
Contributor

sarveshwar-gavhane commented Mar 7, 2017

@oliverfoster can we close #1445 with this PR or in a separate one ?

@oliverfoster
Copy link
Member Author

oliverfoster commented Mar 7, 2017

a separate one would be good 👍

@oliverfoster oliverfoster merged commit 059c26a into master Mar 7, 2017
@tomgreenfield tomgreenfield deleted the issue-1233 branch May 18, 2017 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants