issue-1303: updated to jquery 3.1.1 #1304
Conversation
|
JQuery 3+ doesn't seem to support IE 8. |
|
@brian-learningpool jquery v1 is loaded for IE8 - see scriptLoader.js |
|
Great, thanks for clarifying. |
|
i thoroughly recommend you test this with all your commonly used plugins and extensions. it may break some of the more outlandish ones. |
|
I guess we need a full regression test on a course with the core plugins before this is merged? |
|
I'm not so much worried about the core plugins. It's more 3rd party plugins I'm concerned will break. We need a way to mitigate that. I'm a bit lost in the jQuery migration docs. Perhaps you could have a read and suggest a decent course of action? |
|
I will read when I get a chance. Is there a pressing reason to upgrade to JQuery v3 at this moment or could it wait until the next major release of the framework? |
|
It can wait until we're all happy. |
|
@brian-learningpool it's really just to take advantage of v3 (supposedly) being faster than v2 |
|
I just used JQuery v3 (and the updated inview) in a build where I was testing some updates made to confidenceSlider. Didn't notice any problems but it wasn't the most exhaustive of tests by any means. Only checked in Firefox for a start. |
|
should we stick a post on the forums asking people to test this (and maybe inview as well)? |
|
Hi @moloko, to answer your question (apologies for the delay), I think yes, we we should ask forum users to test this. |
|
no feedback from forum users; agreed with @brian-learningpool to put this on hold until 02/02/17 |
#1303