Added ES5 shim for IE 8 #1346
Merged
Added ES5 shim for IE 8 #1346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've added the shim from https://github.com/inexorabletash/polyfill/blob/master/es5.js. This provides implementations for: - Object.getPrototypeOf - Object getOwnPropertyNames - Object.create - Object.defineProperty - Object.defineProperties - Object.keys - Function.prototype.bind - Array.isArray - Array.prototype.indexOf - Array.prototype.lastIndexOf - Array.prototype.every - Array.prototype.some - Array.prototype.forEach - Array.prototype.map - Array.prototype.filter - Array.prototype.reduce - Array.prototype.reduceRight - String.prototype.trim - Date.now - Date.prototype.toISOString
This was referenced Nov 29, 2016
oliverfoster
reviewed
Dec 5, 2016
Conditinally loaded via Modernizr now rather than conditionals in index.html.
|
Good point, @oliverfoster. This is now done, tested locally in IE 8. |
moloko
approved these changes
Dec 15, 2016
oliverfoster
approved these changes
Dec 15, 2016
|
ta dude |
lc-thomasberger
approved these changes
Dec 16, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added the shim from https://github.com/inexorabletash/polyfill/blob/master/es5.js.
This provides implementations for: