Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue/1435 - Add instruction to article / block schema #1740

Merged
merged 4 commits into from
Sep 5, 2017
Merged

Issue/1435 - Add instruction to article / block schema #1740

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1cc8eae
Added support for instruction text
guywillis Aug 18, 2017
cf50b0c
Added support for instruction text
guywillis Aug 18, 2017
00848fb
Removed redundant help field and added a title
guywillis Aug 18, 2017
c11fbce
Removed redundant help field and added a title
guywillis Aug 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/core/schema/article.model.schema
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,15 @@
"validators": [],
"translatable": true
},
"instruction": {
"type": "string",
"required": false,
"default": "",
"inputType": "Text",
"validators": [],
"help": "This is the instruction text",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I know all the others are exactly like this, but I do think these would look better with a title of 'Instruction text' and no help text...

I don't know why I didn't change these when I did all the select-to-boolean changes

"translatable": true
},
"_classes": {
"type": "string",
"default": "",
Expand Down
9 changes: 9 additions & 0 deletions src/core/schema/block.model.schema
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,15 @@
"validators": [],
"translatable": true
},
"instruction": {
"type": "string",
"required": false,
"default": "",
"inputType": "Text",
"validators": [],
"help": "This is the instruction text",
"translatable": true
},
"_classes": {
"type": "string",
"default": "",
Expand Down