Update sharing options (legacy) #2351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #2345.
moloko
approved these changes
Feb 12, 2019
chetan-hajare
approved these changes
Feb 21, 2019
lc-thomasberger
approved these changes
Feb 25, 2019
There was a problem hiding this comment.
Shall we add the following or similar to package.json? I know it's not hooked up to anything yet but at the very least it would provide a signpost.
"authoringTool": ">=0.7"Edit: this field is added by #2362.
src/core/schema/course.model.schema
Outdated
| "ref": "user" | ||
| }, | ||
| "title": "Share with specific users", | ||
| "help": "Specifies which colleagues will be able to see this course from the 'Shared courses' option" |
There was a problem hiding this comment.
- Suggest sticking to
usersinstead ofcolleagues. - Suggest we reword this so it doesn't specifically reference
'Shared courses'since the terminology/filtering may change in the near future.
cahirodoherty-learningpool
approved these changes
May 1, 2019
moloko
approved these changes
May 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2345. Duplicate of #2346.
💀 Need to discuss exactly when this should be merged, as it will break authoring tools older than v0.7.0 due to the new
Usersinput type.