Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue/2415: Fix ItemsComponentModel inheritance chain #2416

Merged
merged 1 commit into from
May 13, 2019
Merged

issue/2415: Fix ItemsComponentModel inheritance chain #2416

merged 1 commit into from
May 13, 2019

Conversation

oliverfoster
Copy link
Member

@oliverfoster oliverfoster commented Apr 12, 2019 •
edited
Loading

#2415

  • Stopped QuestionModel.extend from modifying ItemsComponentModel.prototype.constructor which was causing QuestionModel to appear in the inheritance chain of ItemsComponentModel. The process of blending QuestionModel and ItemsComponentModel now takes only the own properties from ItemsComponentModel.prototype, minus the constructor function and brings them into a blended class first.
    (The constructor function is assigned by Backbone as an enumerable property as part of the .extend process.)

@oliverfoster oliverfoster self-assigned this Apr 12, 2019
@moloko moloko merged commit b6988c3 into master May 13, 2019
@moloko moloko deleted the issue/2415 branch May 13, 2019 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@danielstorey danielstorey danielstorey approved these changes

@moloko moloko moloko approved these changes

Assignees

@oliverfoster oliverfoster

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oliverfoster @moloko @danielstorey @cahirodoherty-learningpool