Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed #2441 #2444

Merged
merged 3 commits into from
Aug 2, 2019
Merged

fixed #2441 #2444

merged 3 commits into from
Aug 2, 2019

Conversation

NayanKhedkar
Copy link
Member

Fixed #2441 and also changes the calling of copy task now it's only allowed to copying modified files.

@NayanKhedkar NayanKhedkar mentioned this pull request May 30, 2019
Closed
oliverfoster
oliverfoster reviewed May 30, 2019
View reviewed changes
grunt/config/watch.js Outdated Show resolved Hide resolved
grunt/config/watch.js Show resolved Hide resolved
oliverfoster
oliverfoster approved these changes May 31, 2019
View reviewed changes
Copy link
Member

@oliverfoster oliverfoster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👁

brian-learningpool
brian-learningpool approved these changes Jun 3, 2019
View reviewed changes
Copy link
Member

@brian-learningpool brian-learningpool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

moloko
moloko approved these changes Aug 2, 2019
View reviewed changes
Copy link
Contributor

@moloko moloko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have verified that this fixes #2441

@moloko moloko merged commit dce9f48 into master Aug 2, 2019
@moloko moloko deleted the issue/#2441 branch August 2, 2019 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverfoster oliverfoster oliverfoster approved these changes

@brian-learningpool brian-learningpool brian-learningpool approved these changes

@moloko moloko moloko approved these changes

@tomgreenfield tomgreenfield Awaiting requested review from tomgreenfield

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Grunt, build & changes to libraries.
4 participants
@NayanKhedkar @moloko @brian-learningpool @oliverfoster