-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Amends #2392: help text improvements #2552
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Totally agree this is much clearer, my only comment is that because _htmlClassName
has been available in a released version of the FW (v4.3.0) you're introducing a breaking change by doing this.
You could either make this change only v5 adapt - or add a fallback and include it in both.
Because it's only been available for a short while I think the actual risk of it breaking anything is very low, so for simplicity's sake I'd slightly favour changing this as part of v5...
Updated this PR to return to use of |
One thing to mention, developers used to JSX and React will already be used to classes being called className. If we go down the path of using React for the front end it may not be necessary to change the property name. |
This PR changesIt clarifies some Titles in various schemas and adds some Help texts._htmlClassName
to_htmlClasses
.Reference #2392