Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amends #2392: help text improvements #2552

Merged
merged 2 commits into from
Oct 30, 2019

Conversation

chucklorenz
Copy link
Member

@chucklorenz chucklorenz commented Oct 18, 2019

This PR changes _htmlClassName to _htmlClasses. It clarifies some Titles in various schemas and adds some Help texts.

Reference #2392

Copy link
Contributor

@moloko moloko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally agree this is much clearer, my only comment is that because _htmlClassName has been available in a released version of the FW (v4.3.0) you're introducing a breaking change by doing this.

You could either make this change only v5 adapt - or add a fallback and include it in both.

Because it's only been available for a short while I think the actual risk of it breaking anything is very low, so for simplicity's sake I'd slightly favour changing this as part of v5...

@chucklorenz
Copy link
Member Author

chucklorenz commented Oct 18, 2019

Updated this PR to return to use of _htmlClassName so that the amends to Titles and Help could continue toward master. I'll create another PR for _htmlClasses against release/v5. (PR has been created: #2555)

@Link2Twenty
Copy link

One thing to mention, developers used to JSX and React will already be used to classes being called className. If we go down the path of using React for the front end it may not be necessary to change the property name.

@moloko moloko merged commit 242ea2a into adaptlearning:master Oct 30, 2019
@moloko moloko changed the title Amends #2392: _htmlClassName Amends #2392: help text improvements Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants