#2639 expose _requireCompletionOf for course / contentObject / articl… #2654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e / block to authoring tool (#2653)
* Resolves #2377, adds ESLint as a dev dependency Includes .eslintrc file defaulted to standardjs with some caveats, e.g. 4 spaces rather than 2, semicolons allowed, etc. (See 'rules' for details.) Some common common globals (Backbone, underscore) have been added but there are bound to be more required. * Added .eslintignore file * Removed JSCS and JSHint * Added 'prettier' This should go some way to relieving coding style issues. * Switched to 2 space indentation, consistent with v5 branch Also changed line width from 80 characters. * Removed 'prettier' After some evaluation, I think this is too opinionated for our codebase. * Added 'npm run lint' command * Changes from manual lint fix * Correct .eslintignore All .js files in /src/core/libraries are now being ignored. * More manual fixes Also allowing ES6 code in /grunt folder. * Added enforcement of semi-colons to ESLint rules * Reverted formatting on ternary operators * Added operator-linebreak to .eslintrc This preserves existing ternary operators. Also, minor fixes. * Cleared final two linting errors Also removed .prettierrc.json, as this was not required.
|
@jamesrea83 conflicts ^ |
# Conflicts: # src/core/schema/block.model.schema Resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e / block to authoring tool
#2639