Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue/2845 Presentation component save+restore #2846

Merged
merged 6 commits into from
Jul 30, 2020
Merged

issue/2845 Presentation component save+restore #2846

merged 6 commits into from
Jul 30, 2020

Conversation

olivermartinfoster
Copy link
Contributor

@olivermartinfoster olivermartinfoster commented Jul 23, 2020 •
edited by oliverfoster
Loading

#2845
Presentation components hotgraphic and accordion will keep visited states (narrative will also but there is no visible representation of visited states in narrative).

This should all carry on working as before except some crucial QuestionModel only behaviour is now also accessible to ComponentModel and by extension ItemsComponentModel.

Changed

  • Moved _attemptStates API from QuestionModel to ComponentModel
  • Moved _userAnswer API from QuestionModel to ComponentModel

Added

  • ItemsComponentModel save and restore behaviour
  • ComponentModel._userAnswer reset behaviour

Test with spoor pr#197 or using spoor branch issue/2805
Use scorm_test_harness.html to check save/restore

@olivermartinfoster olivermartinfoster added this to the Adapt v6 milestone Jul 23, 2020
@olivermartinfoster olivermartinfoster self-assigned this Jul 23, 2020
@olivermartinfoster olivermartinfoster changed the title issue/2845 Presenation component save/restore issue/2845 Presentation component save/restore Jul 23, 2020
@olivermartinfoster olivermartinfoster changed the title issue/2845 Presentation component save/restore issue/2845 Presentation component save+restore Jul 23, 2020
moloko
moloko approved these changes Jul 23, 2020
View reviewed changes
Copy link
Contributor

@moloko moloko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code 👓

cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Jul 24, 2020
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

kirsty-hames
kirsty-hames approved these changes Jul 30, 2020
View reviewed changes
Copy link
Contributor

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 Tested in latest Chrome, Firefox, iPhone iOS 13.5.1, iPad iOS 10.3.4

@oliverfoster oliverfoster merged commit bc205f8 into master Jul 30, 2020
@oliverfoster oliverfoster deleted the issue/2845 branch July 30, 2020 12:31
@kirsty-hames
Copy link
Contributor

Visited states kept on browser refresh too @oliverfoster

@moloko moloko mentioned this pull request Nov 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moloko moloko moloko approved these changes

@kirsty-hames kirsty-hames kirsty-hames approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@tomgreenfield tomgreenfield Awaiting requested review from tomgreenfield

Assignees

@olivermartinfoster olivermartinfoster

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@olivermartinfoster @kirsty-hames @moloko @cahirodoherty-learningpool @oliverfoster