correct typo in icons.less #2960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moloko
approved these changes
Oct 29, 2020
tomgreenfield
approved these changes
Oct 30, 2020
|
I think you'll also need to update the fonts and selection.json too as if they get imported into Icomoon they'll contain the class typo. |
|
@guywillis on it! |
|
FYI- Large numbers of changes appear in selection.json. Apparently icomoon is generating json props in a slightly different order. Only 2 changes made by me: fixed typo and incremented minor version from 0 to 1. |
moloko
approved these changes
Nov 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #2959
changed .icon-exlcamation to .icon-exclamation