Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Language set from param #3086

Merged
merged 7 commits into from
Apr 12, 2021
Merged

Language set from param #3086

merged 7 commits into from
Apr 12, 2021

Conversation

cahirodoherty-learningpool
Copy link
Contributor

Work arising from suggestion on adaptlearning/adapt-contrib-languagePicker#46

@cahirodoherty-learningpool cahirodoherty-learningpool mentioned this pull request Mar 18, 2021
Closed
moloko
moloko reviewed Mar 18, 2021
View reviewed changes
Copy link
Contributor

@moloko moloko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure about removing the return from onLoadCourseData? Pretty sure changing _activeLanguage automatically triggers a call to loadCourseData.

src/core/js/models/configModel.js Outdated Show resolved Hide resolved
src/core/js/models/configModel.js Outdated Show resolved Hide resolved
@moloko
Copy link
Contributor

moloko commented Apr 6, 2021

looks great - just one thought: might want to allow setting of _defaultDirection too for RTL languages? again, a nice short param would be good e.g. "dir" - so you'd end up with something like ?lang=ar&dir=rtl

I'll do a PR for the URLSearchParams polyfill in a sec

moloko
moloko approved these changes Apr 6, 2021
View reviewed changes
Copy link
Contributor

@moloko moloko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the comment for setValuesFromURLParams needs updating a little now but otherwise this looks good

@cahirodoherty-learningpool
Copy link
Contributor Author

This will also resolve #3011

@cahirodoherty-learningpool cahirodoherty-learningpool mentioned this pull request Apr 8, 2021
Closed
@oliverfoster oliverfoster merged commit 6b65065 into master Apr 12, 2021
@oliverfoster oliverfoster deleted the languageSetFromParam branch April 12, 2021 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eleanor-heath eleanor-heath eleanor-heath approved these changes

@oliverfoster oliverfoster oliverfoster approved these changes

@moloko moloko moloko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cahirodoherty-learningpool @moloko @oliverfoster @eleanor-heath