Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Tightening glob pattern for FW-level tests #3612

Merged
merged 6 commits into from
Oct 4, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 15 additions & 6 deletions test.js
Original file line number Diff line number Diff line change
Expand Up @@ -87,16 +87,25 @@ function populateTestFiles(testFormat) {

// otherwise, only include test files for plugins present in the course config
const config = JSON.parse(fs.readFileSync(path.join(argumentValues.outputdir, 'course', 'config.json')));
const plugins = config?.build?.includes || [];

const plugins = config?.build?.includes;
const globSuffix = testFormat === 'e2e' ? 'e2e/*.cy.js' : 'unit/*.js';

const testFiles = plugins.map(plugin => {
return `**/${plugin}/test/${globSuffix}`;
});
// Set a wider glob as default and limit to included plugins if that is set
let testFiles = [`**/*/test/${globSuffix}`];

const hasDefinedIncludes = Boolean(plugins?.length);
if (hasDefinedIncludes) {
testFiles = plugins.map(plugin => {
return `**/${plugin}/test/${globSuffix}`;
});
}

// Add the framework level test files
testFiles.push(`**/test/${globSuffix}`);
if (testFormat === 'e2e') {
testFiles.push(`./test/${globSuffix}`);
} else {
testFiles.push('<rootDir>/test/unit/*.js');
}

return testFiles.join(',');
}
Expand Down