Skip to content

Commit

Permalink
src: remove util-inl.h include in node.h
Browse files Browse the repository at this point in the history
`node.h` may only include public APIs, which `util-inl.h` is not.
There does not seem to be any reason for including it, so remove it,
because otherwise native addon compilation is broken due to us not
shipping the `util-inl.h` header.

Refs: nodejs#27631
Fixes: nodejs#27803
  • Loading branch information
addaleax committed May 21, 2019
1 parent 00ba75e commit 3853b0c
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions src/node.h
Original file line number Diff line number Diff line change
Expand Up @@ -103,14 +103,6 @@
# endif
#endif

#if defined(NODE_WANT_INTERNALS) && NODE_WANT_INTERNALS
// Internally, do not include util-inl.h into files unless they need it's
// inline definitions.
#else
// Externally, it must be included for backwards API compatibility.
# include <util-inl.h>
#endif

// Forward-declare libuv loop
struct uv_loop_s;

Expand Down

1 comment on commit 3853b0c

@sam-github
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I included it because some of our cctest code appeared to me to assume it was present, so I thought it was part of our public API, but I was clearly mistaken. This fix LGTM.

Please sign in to comment.