Skip to content

Commit

Permalink
src: add overlooked handle to cleanup
Browse files Browse the repository at this point in the history
The `Environment::destroy_ids_timer_handle` should be cleaned up
by `Environment::CleanupHandles()`. Fix that by adding it to the list.

This partially fixes a cctest.

Ref: nodejs#14206
  • Loading branch information
addaleax committed Aug 10, 2017
1 parent 97c4394 commit 5a0ee6d
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions src/env.cc
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,10 @@ void Environment::Start(int argc,
reinterpret_cast<uv_handle_t*>(&idle_check_handle_),
close_and_finish,
nullptr);
RegisterHandleCleanup(
reinterpret_cast<uv_handle_t*>(&destroy_ids_timer_handle_),
close_and_finish,
nullptr);

if (start_profiler_idle_notifier) {
StartProfilerIdleNotifier();
Expand Down

0 comments on commit 5a0ee6d

Please sign in to comment.