Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node v18 support #6

Closed
mcollina opened this issue Jun 20, 2022 · 2 comments · Fixed by #7
Closed

Node v18 support #6

mcollina opened this issue Jun 20, 2022 · 2 comments · Fixed by #7

Comments

@mcollina
Copy link

When adding support to my module to Node v18, I had the following error:

node: symbol lookup error: /home/matteo/repositories/synchronous-worker/build/Release/synchronous_worker.node: undefined symbol: _ZN4node17CreateEnvironmentEPNS_11IsolateDataEN2v85LocalINS2_7ContextEEERKSt6vectorISsSaISsEESA_NS_16EnvironmentFlags5FlagsENS_8ThreadIdESt10unique_ptrINS_21InspectorParentHandleESt14default_deleteISF_EE

Note I have this error only on Linux and not on Mac.
addaleax added a commit that referenced this issue Jun 20, 2022
@addaleax
Use C++11 ABI on Node.js 18.x+ on Linux
90af209 
Fixes: #6
addaleax added a commit that referenced this issue Jun 20, 2022
@addaleax
Use C++11 ABI on Node.js 18.x+ on Linux
bff2832 
Fixes: #6
Refs: nodejs/node#36634
@addaleax addaleax mentioned this issue Jun 20, 2022
Merged
addaleax added a commit that referenced this issue Jun 20, 2022
@addaleax
Use C++11 ABI on Node.js 18.x+ on Linux (#7)
1e015a2 
Fixes: #6
Refs: nodejs/node#36634
@addaleax
Copy link
Owner

📦 [email protected]

@mcollina
Copy link
Author

Thanks @addaleax! This is amazing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use C++11 ABI on Node.js 18.x+ on Linux addaleax/synchronous-worker
2 participants
@mcollina @addaleax