Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(infra-apps): update kured from 2.14 to 2.15 #725

Merged
merged 1 commit into from
Jun 20, 2022
Merged

feat(infra-apps): update kured from 2.14 to 2.15 #725

merged 1 commit into from
Jun 20, 2022

Conversation

vmaillot
Copy link
Contributor

@vmaillot vmaillot commented Jun 20, 2022 •
edited
Loading

Signed-off-by: Valentin Maillot [email protected]

Description

With this release kured will retry to cordon and uncordon a node in case it fails.
This should prevent nodes from being "Unschedulable" forever. Also kured will hold the node-lock until uncordoning
and the lock-release succeeded to avoid reproducing the same issue everywhere. See #486
for more details.

Issues

Checklist

  • This PR contains a description of the changes I'm making
  • I updated the version in Chart.yaml
  • I updated applicable README.md files using pre-commit run
  • I documented any high-level concepts I'm introducing in docs/
  • CI is currently green and this is ready for review
  • I am ready to test changes after they are applied and released

@github-actions github-actions bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 20, 2022
@vmaillot vmaillot marked this pull request as ready for review June 20, 2022 08:28
@vmaillot vmaillot requested a review from a team as a code owner June 20, 2022 08:28
@vmaillot vmaillot requested review from eyenx and isantospardo and removed request for a team June 20, 2022 08:28
@eyenx
Copy link
Member

eyenx commented Jun 20, 2022

Rebase

hairmare
hairmare approved these changes Jun 20, 2022
View reviewed changes
Copy link
Contributor

@hairmare hairmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, once rebased

@github-actions github-actions bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 20, 2022
@github-actions github-actions bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 20, 2022
@vmaillot vmaillot merged commit d2cb6a7 into main Jun 20, 2022
@vmaillot vmaillot deleted the feat/update-kured-2.15 branch June 20, 2022 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hairmare hairmare hairmare approved these changes

@eyenx eyenx Awaiting requested review from eyenx eyenx is a code owner automatically assigned from adfinis/helm-charts

@isantospardo isantospardo Awaiting requested review from isantospardo isantospardo is a code owner automatically assigned from adfinis/helm-charts

Assignees
No one assigned
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vmaillot @eyenx @hairmare