Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow leading zero for NextTick #30

Merged
merged 1 commit into from
Jul 21, 2023
Merged

fix: allow leading zero for NextTick #30

merged 1 commit into from
Jul 21, 2023

Conversation

millotp
Copy link
Contributor

@millotp millotp commented Jul 21, 2023

The fixes #29 by allowing leading zero on minute and hour positions, by casting to int before comparing with "0".

@millotp millotp requested a review from adhocore as a code owner July 21, 2023 07:11
adhocore
adhocore approved these changes Jul 21, 2023
View reviewed changes
Copy link
Owner

@adhocore adhocore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really cool, thanks.

@adhocore adhocore merged commit 5a6b134 into adhocore:main Jul 21, 2023
10 checks passed
@adhocore
Copy link
Owner

released https://github.com/adhocore/gronx/releases/tag/v1.6.4

@millotp
Copy link
Contributor Author

millotp commented Jul 21, 2023

Thanks for the reactivity !

@adhocore
Copy link
Owner

no worries, may i ask to leave a star ⭐ on the gronx repo too? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adhocore adhocore adhocore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NextTick fails with 00 * * * *
2 participants
@millotp @adhocore