Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 0 is forbidden for day #32

Merged
merged 1 commit into from
Sep 20, 2023
Merged

fix: 0 is forbidden for day #32

merged 1 commit into from
Sep 20, 2023

Conversation

millotp
Copy link
Contributor

@millotp millotp commented Sep 19, 2023

According to the cron specification, the allowed values for the day segment must be between 1-31, but currently the cron * * 0 * * is allowed.

This PR aims at making IsValid("* * 0 * *") return false.

@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2023

Codecov Report

Merging #32 (8aee396) into main (5a6b134) will not change coverage.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##             main      #32   +/-   ##
=======================================
  Coverage   94.78%   94.78%           
=======================================
  Files           9        9           
  Lines         594      594           
=======================================
  Hits          563      563           
  Misses         16       16           
  Partials       15       15           
Files Changed Coverage Δ
checker.go 100.00% <100.00%> (ø)
validator.go 100.00% <100.00%> (ø)

@adhocore
Copy link
Owner

thank you very much for your PR. i will check next day, is that okay?

@millotp
Copy link
Contributor Author

millotp commented Sep 19, 2023

Hey, no problem thanks for the response

@adhocore adhocore merged commit 06e7337 into adhocore:main Sep 20, 2023
12 checks passed
@adhocore
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants