Had issues on windows - fixed them + added custom descriptors support to Shell #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l write to the same files created.
…s try at the same time it will give a permission error
…- because <eol> will do exactly that
… out pid higher test which is not always true
…indows + support for custom pipes descriptor passed to execute method
|
Fixes #76 |
|
thank you very much. what do you think, should we add some cicd that runs on windows? |
|
@adhocore cicd on windows will be great. Like it or not windows should be supported 😄 |
|
thank you very much, looks great 💯 |
|
Yes tested it in win10 11 and server... also tested on nix. Happy to contribute. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Colorstests which were comparing\ntoPHP_EOL- which is not reliable and fails on windows.unlinkin tests to avoid warnings.stdoutandstderr- changed that and added support for "custom" pipes declaration passed toexecute().isWindows()inShellShell- checks to see they are a viable resource.Tested it again passing all tests on windows and linux... ✔️
🚦 PLEASE - add a new release, 1.2 is the latest and doesn't include the
$envbug fix which was merged later.🚀 Great project - lightweight, clean and neat