Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI broken with Gradio 3.2x #338

Closed
akx opened this issue Mar 26, 2023 · 12 comments
Closed

UI broken with Gradio 3.2x #338

akx opened this issue Mar 26, 2023 · 12 comments
Labels
bug Something isn't working

Comments

@akx
Copy link
Collaborator

akx commented Mar 26, 2023 •
edited
Loading

For end users: For the time being, I would recommend not updating AUTOMATIC1111/stable-diffusion-webui past e.g. a9eab236d7e8afa4d6205127904a385b2c43bb24 if you rely on this extension.

AUTOMATIC1111/stable-diffusion-webui@9f0da9f updates Gradio from 3.16.x to 3.22; this seems to break the JavaScript in this extension despite the fixes in #316:

Cannot read properties of null (reading 'append') TypeError: Cannot read properties of null (reading 'append')
    at dynamic_prompting.js?1679820957.2935863:15:49
    at runCallback (script.js?1679821875.4057686:38:9)
    at script.js?1679821875.4057686:44:31
    at Array.forEach (<anonymous>)
    at executeCallbacks (script.js?1679821875.4057686:44:11)
    at MutationObserver.<anonymous> (script.js?1679821875.4057686:56:9)

etc.
@akx akx added the bug Something isn't working label Mar 26, 2023
@akx akx pinned this issue Mar 26, 2023
@adieyal
Copy link
Owner

adieyal commented Mar 26, 2023

@akx I can look into it later today if you aren't already working on it.

@akx
Copy link
Collaborator Author

akx commented Mar 26, 2023

@adieyal Please do! I just noticed this while working on the new wildcard stuff. I'm using an older webui for now :)

@akx akx changed the title JS broken with Gradio 3.2x UI broken with Gradio 3.2x Mar 26, 2023
@akx akx mentioned this issue Mar 26, 2023
Closed
@modulator
Copy link

Yup - I think same issue for me! Basically Dynamic Prompts doesnt show up on Text2Img panel...

@adieyal
Copy link
Owner

adieyal commented Mar 27, 2023

I'm afraid that I can't get my webui to work with the newest version. I'm currently using 33b85391 which is more or less as far as I can go before it no longer runs on my setup. I have made some changes which fixed some versions here: https://github.com/adieyal/sd-dynamic-prompts/tree/bug/gradio3.2 but I can't tell whether that would fix the most recent webui.

@rektobot
Copy link

i noticed you closed the mac thread, you still need me to revert and run some tests? also of note, typically when auto1111 shits the bed after an update i cant even get dynamic-prompts to show up in the webui most the time without manual install cell before start-up, let alone run iterations. this past weekend after i installed ngrok for tunneling i was able to get usable batches out of it with exception of magic prompt being broken and throwing errors. i was doing combinatorials maxed out, 300 batches of 3 imgs and stuff and it didnt hiccup or throw any errors at all. in conclusion gradio is comped dogshit.

@adieyal
Copy link
Owner

adieyal commented Mar 28, 2023 via email

@adieyal
Copy link
Owner

adieyal commented Mar 28, 2023

I have pushed a fix which works on my end. If anyone wants to test, please checkout to the bug/gradio3.2 branch

git checkout -b bug/gradio3.2
git pull https://github.com/adieyal/sd-dynamic-prompts.git bug/gradio3.2

You'll need to refresh your browser to test. Please let me know if it has fixed it on your setup.

@adieyal adieyal mentioned this issue Mar 28, 2023
Closed
@rektobot
Copy link

it seems to still be happening with the UI issue that a lot of people are experiencing with the gradio update. dynamic-prompts still runs every batch but now i cant open the menu, whenever i try the arrow tick to open & adjust settings it freezes the interface then it times out & i have to reload. when i reload i run a batch, my settings remain the same in dynamic prompts w/o magic prompt but i cant open the extension. it doesnt throw any errors after the initial batch error and puts the csv in the outputs directory with the imgs. i need to revert back to the last reasonably 'stable' commit anyway because a lot of stuff is throwing up errors now and the interface is all wonky, the preview screen is tiny, those stupid gradio animations freeze everything so i have to mess with the css file, hypernetworks decided to just do whatever the eff they want. this is the only error im getting out of dp now:

Traceback (most recent call last):
File "/content/gdrive/MyDrive/sd/stable-diffusion-webui/modules/scripts.py", line 417, in process
script.process(p, *script_args)
File "/content/gdrive/MyDrive/sd/stable-diffusion-webui/extensions/sd-dynamic-prompts/sd_dynamic_prompts/dynamic_prompting.py", line 388, in process
GeneratorBuilder(
TypeError: set_is_magic_prompt() got an unexpected keyword argument 'batch_size'

@adieyal
Copy link
Owner

adieyal commented Mar 28, 2023

Traceback (most recent call last): File "/content/gdrive/MyDrive/sd/stable-diffusion-webui/modules/scripts.py", line 417, in process script.process(p, *script_args) File "/content/gdrive/MyDrive/sd/stable-diffusion-webui/extensions/sd-dynamic-prompts/sd_dynamic_prompts/dynamic_prompting.py", line 388, in process GeneratorBuilder( TypeError: set_is_magic_prompt() got an unexpected keyword argument 'batch_size'

I'm not sure what's going on with your slow down, but re the exception. Could you confirm that you're using the latest dynamicprompts library? If the interface lets you, go to the need help? section. The version is listed there. It should be v0.20.0. It should upgrade automatically but perhaps something prevented it from do it. If you're using an older version, the run python -m pip install dynamicprompts==0.20.0. I think that should sort at least one of your issues.

@akx akx unpinned this issue Mar 28, 2023
@rektobot
Copy link

rektobot commented Mar 28, 2023 via email

@adieyal
Copy link
Owner

adieyal commented Mar 28, 2023

heres what ive been doing recently and it seemed to work for the most past because updating from the webui was always a gamble at best and the cell from the readme in the repo worked if i edited it removing the magic prompts portion. now i just go to the main repo and look for the latest date and see if my files are up to date with it if not then i just c/p the raw files right into the right directory. i always manage to forget to do the requirements.txt tho. i noticed today my dynamic-prompting.py was still on 2.8.10 so thats probably the issue. i prefer updating from a cell on colab tbh, the webui is too finicky Sent with Proton Mail secure email.

In that case you should at least run something like:

!cd extensions/sd-dynamic-prompts
!git pull origin main

so that you don't have to copy files manually.

@rektobot
Copy link

rektobot commented Mar 28, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@akx @adieyal @modulator @rektobot