Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make version compatibility checking stricter #437

Closed
akx opened this issue May 22, 2023 · 4 comments · Fixed by #449
Closed

Make version compatibility checking stricter #437

akx opened this issue May 22, 2023 · 4 comments · Fixed by #449
Labels
bug Something isn't working enhancement New feature or request

Comments

@akx
Copy link
Collaborator

akx commented May 22, 2023

We've had a bunch of issues now and in the past where people haven't upgraded dynamicprompts along with sddp.

I think the UI should make it very clear if you're using an incompatible/old version of DP, e.g. by making the Dynamic Prompts accordion a screaming orange or something.

We could even (try to) offer a button to upgrade DP too (though it will probably require a restart of the WebUI to properly take).

@akx akx added bug Something isn't working enhancement New feature or request labels May 22, 2023
@adieyal
Copy link
Owner

adieyal commented May 22, 2023

Did you see my commit from earlier today?
72f21de

It only writes to the terminal - a visual indication would be helpful.

Do you know why it isn't updating automatically for some people? install.py should run unless there is some way to disable it via a flag.

@akx
Copy link
Collaborator Author

akx commented May 22, 2023

Ah, no, I didn't see that :)

install.pys definitely are run by launch.py but then there are folks who don't use launch.py (such as, ahem, yours truly)...

@adieyal
Copy link
Owner

adieyal commented May 22, 2023

How are you disabling it? Do you think others are doing the same?

@akx
Copy link
Collaborator Author

akx commented May 23, 2023

I just use webui.py instead, and only run launch.py when I've pulled a new version of the webui.

I don't know how common that might be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants