-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework installer and requirement checks #449
Conversation
Shoot - didn't realise that you were working on this now. I just pushed some temporary changes in anticipation of your update. Feel free to revert my PR. |
@adieyal No worries, rebased :) |
I'm getting a ModuleNotFoundError: |
@adieyal ah, good catch... |
@adieyal I pushed a new commit that adds compatibility imports for TOML and Packaging from |
This PR:
requirements.txt
to the standard TOMLproject.dependencies
listinstall.py
to move everything version-specific tosd_dynamic_prompts.version_tools
requirements
. No good reason not to, IMO :)packaging
's utilities to check whether the currently installeddynamicprompts
version matches our specifier; this means e.g. future [compatible] versions of dynamicprompts work without having to bump the requirement here; e.g.~=0.25.2
is fine with any 0.25 series >= 0.25.2,~=0.25
is fine with any 0.x >= 0.25, etc. This also allows using actual ranges, if we need to, in the requirements, e.g.~=0.25.2,<0.30
(but hopefully it never gets to that).Screenshot
Follows up on #447, #450
Fixes #437