Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wildcard tab JS rework #364

Merged
merged 5 commits into from
Apr 3, 2023
Merged

Wildcard tab JS rework #364

merged 5 commits into from
Apr 3, 2023

Conversation

akx
Copy link
Collaborator

@akx akx commented Mar 30, 2023

This PR:

  • adds eslint + prettier for enforcing style and quality in the JS code too
  • reworks the wildcard manager tab's logic
    • Code is now 99% in a single singleton SDDP class that's just initialized with a couple of external things
    • Most communication is handled with an inbox and outbox field instead of really dealing that much with Gradio callbacks
  • modernizes and cleans up the treeview component; I assume SD users don't use legacy browsers

Might want to give this a more thorough testing in case I've missed something :)

@akx akx force-pushed the simplify-wildcard-tab branch 2 times, most recently from c886732 to 312ac6f Compare March 30, 2023 18:57
@akx akx marked this pull request as ready for review March 30, 2023 19:00
@akx akx requested a review from adieyal March 30, 2023 19:01
@adieyal
Copy link
Owner

adieyal commented Mar 30, 2023

Everything works except:

  1. I can't edit files
  2. The dropdown on collections is hard to see as it doesn't have a border. I don't recall that being the case before but I can't be sure.

@akx
Copy link
Collaborator Author

akx commented Mar 30, 2023

Thanks for verifying. I'll try and fix those tomorrow :)

@akx akx marked this pull request as draft March 30, 2023 21:29
@akx akx marked this pull request as ready for review March 31, 2023 06:49
@adieyal adieyal merged commit c5e24d7 into adieyal:main Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants