Skip to content
This repository has been archived by the owner on Oct 14, 2021. It is now read-only.

Solution for issue #408 #518

Merged
merged 1 commit into from
Oct 10, 2021
Merged

Solution for issue #408 #518

merged 1 commit into from
Oct 10, 2021

Conversation

mgndolan
Copy link
Contributor

@mgndolan mgndolan commented Oct 8, 2021

Created a new folder "PhoneLetterCombo" with C# solution to the "Letter Combinations of a Phone Number" problem. This solution is quick, but is not necessarily efficient in terms of memory.

Everything compiles as expected and runs all test cases successfully. The logic was tested against other examples on Leetcode and passed all successfully.

Signed-off-by: Megan Dolan [email protected]

@mgndolan
Resolution to issue #408
857cb74 
Created a new folder "PhoneLetterCombo" with C# solution to the "Letter Combinations of a Phone Number" problem. This solution is quick, but is not necessarily efficient in terms of memory.

Everything compiles as expected and runs all test cases successfully. The logic was tested against other examples on Leetcode and passed all successfully.
aditya109
aditya109 approved these changes Oct 10, 2021
View reviewed changes
Copy link
Owner

@aditya109 aditya109 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mgndolan ! LGTM ! Great work on your PR 👏 ! If you have not please consider starring⭐ this repo to encourage further contributions.

@aditya109 aditya109 linked an issue Oct 10, 2021 that may be closed by this pull request
Letter Combinations of a Phone Number [C#-Solution required] #408
Closed
@aditya109 aditya109 added Great Work ! Credits for working out the issue. Hacktoberfest hacktoberfest-accepted MVP most valuable PR labels Oct 10, 2021
@aditya109
Copy link
Owner

Hi @mgndolan ! Very well written PR code [@mgndolan ]! 🎊
Please expect your name to be featured in the https://github.com/aditya109/git-osp-for-beginners/blob/master/README.md#-contributor-highlights-. Congratulations !

@aditya109 aditya109 merged commit c6ff33c into aditya109:master Oct 10, 2021
@mgndolan
Copy link
Contributor Author

Hi @mgndolan ! Very well written PR code [@mgndolan ]! 🎊 Please expect your name to be featured in the https://github.com/aditya109/git-osp-for-beginners/blob/master/README.md#-contributor-highlights-. Congratulations !

@aditya109 Thank you!! This was my first open source contribution, so I really appreciate the encouragement!

@aditya109
Copy link
Owner

Hi @mgndolan ! Very well written PR code [@mgndolan ]! 🎊 Please expect your name to be featured in the https://github.com/aditya109/git-osp-for-beginners/blob/master/README.md#-contributor-highlights-. Congratulations !

@aditya109 Thank you!! This was my first open source contribution, so I really appreciate the encouragement!

Glad to hear that @mgndolan. Hope this becomes one of the stepping stones in your journey in open-source world.
Have fun and happy hacking !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@aditya109 aditya109 aditya109 approved these changes

Assignees

@mgndolan mgndolan

Labels
Great Work ! Credits for working out the issue. Hacktoberfest hacktoberfest-accepted MVP most valuable PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Letter Combinations of a Phone Number [C#-Solution required]
2 participants
@mgndolan @aditya109