Scheduled weekly dependency update for week 08 #1471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The wheel failed to build on Windows. |
Probably this line Needs to be "Visual Studio 17 2022" See also actions/runner-images#3949 |
|
This line may have to be updated as well, |
- comment out vs-version for setup-msbuild (temporary to see if default works) - set CMAKE_GENERATOR to "Visual Studio 17 2022"
Yes -- I've just commented it out for now which should use the default as it's not clear which specific versions of VS 17.x are actually available on |
|
@josh-hadley Can you also try changing the value in this line to |
- exclude mac python 3.9 (instead of 3.10) - change setup-msbuild vs-version to minimum 17.0 (see https://github.com/microsoft/setup-msbuild#specifying-specific-versions-of-visual-studio-optional)
josh-hadley
approved these changes
Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update lxml from 4.7.1 to 4.8.0.
The bot wasn't able to find a changelog for this release. Got an idea?
Links