chore: change from delayed flow to include consent
#376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
davidnuescheler
changed the title
davidnuescheler
changed the title
delayed flow to include consent
trieloff
reviewed
Jun 28, 2024
scripts/scripts.js
Outdated
Comment on lines
125
to
126
| if (consentStatus === 'declineAll') return false; | ||
| return true; |
There was a problem hiding this comment.
Suggested change
| if (consentStatus === 'declineAll') return false; | |
| return true; | |
| if (consentStatus === 'acceptAll') return true; | |
| return false; |
kptdobe
reviewed
Jul 1, 2024
scripts/scripts.js
Outdated
| if (consentStatus !== null) return mapStatus(consentStatus); | ||
| return new Promise((resolve) => { | ||
| // display consent banner | ||
| document.addEventListener('aem:changeconsent', (e) => { |
There was a problem hiding this comment.
Suggested change
| document.addEventListener('aem:changeconsent', (e) => { | |
| document.addEventListener('aem:consentchange', (e) => { |
There was a problem hiding this comment.
Actually, who fires this event ? Adding an event listener in a check method is not a good practice. If I call the checkConsent method multiple times, the document will have multiple similar listeners.
fkakatie
reviewed
Jul 11, 2024
scripts/consent.js
Outdated
| /* main consent handler */ | ||
| export default async function handleConsent() { | ||
| const mapStatus = (consentStatus) => { | ||
| if (consentStatus === 'declineAll') return false; |
There was a problem hiding this comment.
return consentStatus !== 'declineAll';? Or is that unclear?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changing the flow of loading marketing tech based on a conditions / events such as consent
https://marketing-tech--aem-boilerplate--adobe.aem.page/