[Navigation] Add role attribute on navigation #2727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LSantha
approved these changes
Apr 26, 2024
|
Adobe CLA filled and signed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature Request
Current Behavior :
In european countries using the French Accessibility Guidelines (RGAA) or the Luxembourg guideline (RAWeb1), a role attribute is mandatory on each landmark.
The reason is to keep a compatibility with old browser (that don't support HTML5) or old version of assistive tools.
Expected behavior/code :
Navigation menu should have an ARIA nav with attribute role="navigation"
Environment
Possible Solution :
Add a role attribute on each navigation landmarks.
Additional context :
WAI wiki : https://www.w3.org/WAI/GL/wiki/Using_HTML5_nav_element#Example:The_.3Cnav.3E_element
RGAA 4.1.2 / RAWeb 1 : 12.6.1 https://accessibilite.public.lu/fr/raweb1/criteres.html#test-12-6-1 (in french)