Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WCM Core Email components added for v6.5 #397

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

knennigtri
Copy link
Contributor

Description

New submodule called /email for POC for email pages for ACC/ACS using AEM v6.5.x

  • components - /apps/wknd/components/email
  • client library - /apps/wknd/clientlibs/clientlib-email
  • configuration - /apps/wknd/config/rewriter/email-link-rewrite (core email cmps project said this was required)
  • email page - /content/campaigns/wknd/master/campaign-emails/wknd-email
  • template - /conf/wknd/settings/wcm/templates/email-page
  • template type - /conf/wknd/settings/wcm/template-types/email-page
  • policies - /conf/wknd/settings/wcm/policies/wknd/components/email
  • /email/all creates an aem-guides-wknd.email.all-2.1.3-SNAPSHOT.zip and installs:
    • /apps/wknd-email-packages/application/install/aem-guides-wknd.email.ui.apps-2.1.3-SNAPSHOT.zip
    • /apps/wknd-email-packages/content/install/aem-guides-wknd.email.ui.content-2.1.3-SNAPSHOT.zip
    • /apps/wknd-email-vendor-packages/application/install/core.email.components.content-1.0.0.zip
    • /apps/wknd-email-vendor-packages/application/install/core.email.components.core-1.0.0.jar
  • aem-guides-wknd.email.all-2.1.3-SNAPSHOT.zip artifact is added to wknd/all

Feature request: #396

Motivation and Context

Core Email Components are now supported with WCM Core Components v2.21.2. Adobe gives good documentation for them, but a good example is lacking. Using WKND's brand to highlight these components helps developers investigate the components and gain interest.

How Has This Been Tested?

Core email components 1.0.0 requires AEM 6.5.14+ and Core Components v2.21.2

AEM 6.5.14 with this project integrated with ACS successfully sent the email page from AEM to ACS.
AEM >> ACC has not been tested

Screenshots (if appropriate):

The example email tries to highlight some of the new WCM Email Core components as well as maintaining the basic layout of the original examples that existed with the We.Retail example.
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@SachinMali
Copy link
Contributor

@knennigtri This is great, however instead of a new submodule (email) can this be a separate project like WKND Shared. This will help to have decoupling and somewhat independent development, and release cycle.

@knennigtri
Copy link
Contributor Author

@SachinMali this makes sense, I'll just need a bit of guidance (official repo, publishing to maven, etc...) on how to do that.

@SachinMali
Copy link
Contributor

SachinMali commented Apr 4, 2023

@knennigtri Thanks and sorry for the delay. Please see high-level steps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants