Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved package dependency in classic all project #412

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Conversation

davidjgonzalez
Copy link
Contributor

@davidjgonzalez davidjgonzalez commented Aug 2, 2023

Fixed issue where aem-guides-wknd-shared.ui.content v3.0.0 was being set as a package dependency even in the -classic artifact.

This fix sets aem-guides-wknd-shared.ui.content v3.0.0 as a dep in the cloud artifact, and v2.2.2 as a dep in the classic artifact.

Note that the aem-guides-wknd.all-3.0.0-classic.zip in https://github.com/adobe/aem-guides-wknd/releases/tag/aem-guides-wknd-3.0.0 contains this fix retroactively.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@davidjgonzalez davidjgonzalez added the bug Something isn't working label Aug 3, 2023
@davidjgonzalez davidjgonzalez marked this pull request as ready for review August 3, 2023 18:15
@SachinMali SachinMali merged commit 709bd74 into main Aug 4, 2023
5 checks passed
@davidjgonzalez davidjgonzalez deleted the 3.0.2 branch August 4, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants