Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unnecessary/brittle IT test checks #417

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

davidjgonzalez
Copy link
Contributor

@davidjgonzalez davidjgonzalez commented Aug 8, 2023

Remove checking for error message values as these can change over time.

Motivation and Context

This check will break IT tests for WKND which will block AEM as a Cloud Service releases.

How Has This Been Tested?

Ran IT tests on AEM as a Cloud Service sandbox.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Remove checking for error message values as these can change over time.
@davidjgonzalez davidjgonzalez marked this pull request as ready for review August 8, 2023 20:11
@davidjgonzalez davidjgonzalez merged commit 3509656 into main Aug 8, 2023
5 checks passed
@davidjgonzalez davidjgonzalez deleted the davidjgonzalez-patch-2 branch August 8, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants