Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Artifact override rule required for mvn dependency with classification #209

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

abhishekgarg18
Copy link
Contributor

@abhishekgarg18 abhishekgarg18 commented Aug 7, 2023

for fix #208

@abhishekgarg18 abhishekgarg18 changed the title SKYOPS-58122 adding Artifact override rule required Adding Artifact override rule required for mvn dependency with classification Aug 7, 2023
@rombert
Copy link
Contributor

rombert commented Aug 8, 2023

Changes LGTM, but it would be good if one of @cziegeler @karlpauls or @bosschaert could also take a look.

@cziegeler
Copy link
Contributor

not 100% sure, but I agree that this change looks good :)

@rombert rombert merged commit 4054fc2 into adobe:main Aug 8, 2023
1 check passed
@rombert
Copy link
Contributor

rombert commented Aug 8, 2023

Thanks for your contribution @abhishekgarg18 . I've released it to Maven Central as

<dependency>
  <groupId>com.adobe.aem</groupId>
  <artifactId>aemanalyser-core</artifactId>
  <version>1.4.8</version>
</dependency>

It should be visible within the next 30-60 minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ArtifactRule Overide required for classfication mvn path
3 participants