Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CEXT-2009 Add New Relic support to aio CLI #311

Merged

Conversation

gjmarques
Copy link
Contributor

@gjmarques gjmarques commented Jun 28, 2023

Description

Add New Relic support to log forwarding

Pre-requisite before merging

Related Issue

Log forwarding New Relic support
Add New Relic support to aio CLI

Motivation and Context

Log Forwarding currently supports Splunk and Azure Log Analytics. This PR adds support for New Relic.

How Has This Been Tested?

Auto tests are included

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@shazron
Copy link
Member

shazron commented Jul 6, 2023

@gjmarques:

  1. Does this PR depends on CEXT-2009 Add New Relic support to aio CLI aio-lib-runtime#148 being released?
  2. The tests have failures, can you please check.

@gjmarques
Copy link
Contributor Author

@shazron
Yes this PR depends on adobe/aio-lib-runtime#148
Tests should be fixed

@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Merging #311 (bad6519) into master (491a5ae) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #311   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           65        66    +1     
  Lines         1736      1749   +13     
  Branches       367       367           
=========================================
+ Hits          1736      1749   +13     
Impacted Files Coverage Δ
.../runtime/namespace/log-forwarding/set/new-relic.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shazron shazron merged commit 3968c92 into adobe:master Jul 17, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants