Empty datastream overrides are no longer sent to the Edge Network, reducing potential conflicts with server side routing configurations

[ninaceban]

Description

Related Issue

Motivation and Context

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Improvement (non-breaking change which does not add functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• I have signed the Adobe Open Source CLA or I'm an Adobe employee.
• I have made any necessary test changes and all tests pass.
• I have run the Sandbox successfully.

[carterworks]

Excellent.

Should we also check to see if globalEdgeConfigOverrides is empty, like

if (globalEdgeConfigOverrides && !isEmptyObject(globalEdgeConfigOverrides))

?

[ninaceban]

Excellent.

Should we also check to see if globalEdgeConfigOverrides is empty, like

if (globalEdgeConfigOverrides && !isEmptyObject(globalEdgeConfigOverrides))

?

Yes, good call, we can add an extra check for localEdgeConfigOverrides, for globalEdgeConfigOverrides I don't see somewhere in the code that we initialize it with empty object, unless the validator does that.

[ninaceban]

if (globalEdgeConfigOverrides && !isEmptyObject(globalEdgeConfigOverrides))

Excellent.
Should we also check to see if globalEdgeConfigOverrides is empty, like
if (globalEdgeConfigOverrides && !isEmptyObject(globalEdgeConfigOverrides))
?

Yes, good call, we can add an extra check for localEdgeConfigOverrides, for globalEdgeConfigOverrides I don't see somewhere in the code that we initialize it with empty object, unless the validator does that.

Excellent.
Should we also check to see if globalEdgeConfigOverrides is empty, like
if (globalEdgeConfigOverrides && !isEmptyObject(globalEdgeConfigOverrides))
?

Yes, good call, we can add an extra check for localEdgeConfigOverrides, for globalEdgeConfigOverrides I don't see somewhere in the code that we initialize it with empty object, unless the validator does that.
Carter, thank you, I have added those checks for both, these might come as empty object from the customer.