Renamed message component names to align with other Adobe SDKs #1202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carterworks
requested changes
Oct 24, 2024
| @@ -17,7 +17,7 @@ export default ({ payload, datastreamIdOverride }) => { | |||
| payload, | |||
| datastreamIdOverride, | |||
| getAction() { | |||
| return "privacy/set-consent"; | |||
| return "consent/set-consent"; | |||
There was a problem hiding this comment.
This is part of the Konductor url for set-consent commands and needs to remain as "privacy/set-consent". As is, set-consent commands return a 404 response.
|
In my PR I replaced some instances in |
jonsnyder
approved these changes
Oct 28, 2024
jonsnyder
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rename the following components within the Web SDK:
DecisioningEngine => RulesEngine
LegacyMediaAnalytics => MediaAnalyticsBridge
Privacy => Consent
Related Issue
PDCL-12692
Types of changes
Checklist: