This repository has been archived by the owner on Sep 2, 2021. It is now read-only.
Fix potential crash when reloading Brackets #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Looks good. Merging. |
redmunds
added a commit
that referenced
this pull request
May 23, 2013
Fix potential crash when reloading Brackets
redmunds
added a commit
that referenced
this pull request
Dec 8, 2015
Fix potential crash when reloading Brackets
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reloading Brackets, there is a short period of time where the old V8 context is still around, but has been detached from the browser. Any calls to our V8 extensions during that time will fail. Previously, this would crash. With this change, we simply ignore the request and return
falseto signal that we didn't handle the request.