This repository has been archived by the owner on Sep 2, 2021. It is now read-only.
Don't use NSFileManager api for path existence detection in IsNetworkDrive api. #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@redmunds Can you please review this since you're the one who identifies my pr as the culprit? |
ghost
assigned 
|
I'm still seeing the same problem. Code runs slow in Debug mode so you can watch these phases in this order:
|
|
If I double-click directly on debug executable, it crashes on startup. I saved the crash log if anyone wants to look at it. |
|
@redmunds I added some clarification in adobe/brackets#5277 (comment) and also updated the description of this pull request. |
|
Verified original bug is still fixed. Merging. |
redmunds
added a commit
that referenced
this pull request
Oct 15, 2013
Don't use NSFileManager api for path existence detection in IsNetworkDrive api.
redmunds
added a commit
that referenced
this pull request
Dec 8, 2015
Don't use NSFileManager api for path existence detection in IsNetworkDrive api.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the debug issue (adobe/brackets#5277) introduced by pull request #281 and also fixes adobe/brackets#4410 that pull request tried to fix.This simplifies the code in checking the existence of file/folder path on Mac. The original code added to fix adobe/brackets#4410 is somehow making debug crash issue (adobe/brackets#5277) happening sooner in a debugging session.