Fix for #7220: empty pref file is an empty object, not an error.

This also fixes #7229 which was duped to #7220.
adobe · Mar 20, 2014 · 4c737e3 · 4c737e3
1 parent ee8d3bf
commit 4c737e3
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 6 deletions.
diff --git a/src/preferences/PreferencesBase.js b/src/preferences/PreferencesBase.js
@@ -175,10 +175,15 @@ define(function (require, exports, module) {
 
                     self._lineEndings = FileUtils.sniffLineEndings(text);
 
-                    try {
-                        result.resolve(JSON.parse(text));
-                    } catch (e) {
-                        result.reject(new ParsingError("Invalid JSON settings at " + path + "(" + e.toString() + ")"));
+                    // If the file is empty, turn it into an empty object
+                    if (/^\w*$/.test(text)) {
+                        result.resolve({});
+                    } else {
+                        try {
+                            result.resolve(JSON.parse(text));
+                        } catch (e) {
+                            result.reject(new ParsingError("Invalid JSON settings at " + path + "(" + e.toString() + ")"));
+                        }
                     }
                 });
             } else {

diff --git a/test/spec/PreferencesBase-test-files/empty.json b/test/spec/PreferencesBase-test-files/empty.json
diff --git a/test/spec/PreferencesBase-test.js b/test/spec/PreferencesBase-test.js
@@ -1067,8 +1067,9 @@ define(function (require, exports, module) {
         });
 
         describe("File Storage", function () {
-            var settingsFile = FileSystem.getFileForPath(testPath + "/.brackets.json"),
-                newSettingsFile = FileSystem.getFileForPath(testPath + "/new.prefs"),
+            var settingsFile      = FileSystem.getFileForPath(testPath + "/.brackets.json"),
+                newSettingsFile   = FileSystem.getFileForPath(testPath + "/new.prefs"),
+                emptySettingsFile = FileSystem.getFileForPath(testPath + "/empty.json"),
                 filestorage,
                 originalText;
 
@@ -1207,6 +1208,21 @@ define(function (require, exports, module) {
                     }]);
                 });
             });
+
+            it("is fine with empty preferences files", function () {
+                var filestorage = new PreferencesBase.FileStorage(emptySettingsFile.fullPath),
+                    promise = filestorage.load();
+
+                waitsForDone(promise, "loading empty JSON file");
+                runs(function () {
+                    promise.then(function (data) {
+                        expect(data).toEqual({});
+                    })
+                        .fail(function (error) {
+                            expect("There should have been no error").toEqual("");
+                        });
+                });
+            });
         });
     });
 });