-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Cannot dismiss Find modalbar with keyboard after using Previous or Next buttons #5262
Comments
Nominating for Sprint 32. @rajeshsegu Can you take this one? |
@redmunds I can definitely take this. Thanks for finding the culprit. ;) |
The dialog can be dismissed, but it's not as nice as it should. But it does it's job because you can't do anything else than typing in the input field after clicking a navigator button.
@rajeshsegu Looks like @SAplayer just posted a potential fix. Can you take a look at add comments in #5297? |
Reviewed. Assigned to @redmunds as the core-team owner since it's nominated for Sprint 32. |
@SAplayer I think the code needs a minor change, please fix it. Thanks. @peterflynn @redmunds Otherwise, the fix looks pretty good. |
@rajeshsegu We decided not to take pull #5297, and you said that you would take this one over. We'd like to get this fix in Sprint 33 which ends 10/24. Let me know if you won't be able to work on it by then. |
@rajeshsegu FYI, I submitted a fix for this. |
FBNC @redmunds? Judge, Jury and Executioner... 🔨 |
Closing. |
Enter
orEsc
Result:
Nothing happens
Expected
Find modal bar is dismissed
Seems to be a focus issue -- click back in search field the keyboard works as expected.
The text was updated successfully, but these errors were encountered: