-
Notifications
You must be signed in to change notification settings - Fork 7.6k
"Ctrl + Space" should move to the next entry when the code hint menu popped up. #8142
Comments
@metalbrick Ctrl+Space just pops up the code hints in the case where you need to force them open. You can then navigate to next/previous entries using up/down arrows on keyboard and also PageUp/PageDown keys. |
@redmunds sure the up/down would do the works, but when I was familiar or obsessed with Vim, I was kinda not willing to use arrow keys when coding, I just arbitrarily presumed there're someones are with me; And since the shortcut "ctrl-space" won't be conflict with anything other commands, I would like to suggest that it should implemented with this future, actually I think that might be a very simple UX fix. |
@metalbrick Does Vim have something like code hints, where Ctrl+Space works that way? I'm not familiar with any other editor where Ctrl+Space does what you're asking... |
@peterflynn Vim has "Ctrl+N" that did the same work, Sublime text has the features that I described with "Ctrl+space". |
Making a |
I would like to fix this bug. Where to start with? |
@ramsundhar20 Start by looking at editor/CodeHintManager.js and editor/CodeHintList.js |
Hai, I went through the code in CodeHintList.js, I updated the below line at line number 398 "} else if ((keyCode === KeyEvent.DOM_VK_DOWN)||(event.ctrlKey && (keyCode == KeyEvent.DOM_VK_SPACE))) {" Is this enough? or some more changes needed. I want to verify the fix who can I build brackets and check it? |
@ramsundhar20 That sounds about right. Take a look at How to Hack on Brackets that explains how to get started contributing code. |
The above fix doesn't work. I am working on the proper fix. I will commit it after I verified it. Thank you. |
I made list to toggle using just ctrl, which would be more comfortable than ctrl+space |
ctrl-space is hotkey in Windows to toggles Asian IMEs |
@seantw Not in Win8 any more. |
Hello, I am new to OSS and thought this would be a fair bug to start. I hope it is still good to look into even though it is 2 years old. I think I have the basic idea of how to do this but I am stuck on running Here is my suggested solution: #12251 |
@bmax As mentioned in this previous comment, on the event for the space char also verify that the ctrl key is down something like: |
…n the code hint menu is open (#12251) * Can now move up with ctrl+space. * Changes made suggested by PR * Found a cleaner way to do the alreadyOpen Bool. Still having trouble with the javascript '.' character hints * Remove unneeded var * Fix issues with CodeHints starting with dots * Fix wrong parameter * Changes made suggested by PR * Fix issues with CodeHints starting with dots * Fix issues with CodeHints starting with dots * Fix issues with CodeHints starting with dots * Remove unneeded var * All tests pass.
Otherwise the shortcut is kind of useless.
The text was updated successfully, but these errors were encountered: