Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Localizing package metadata in Extension Manager #8953

Closed
jasonsanjose opened this issue Sep 3, 2014 · 8 comments
Closed

Localizing package metadata in Extension Manager #8953

jasonsanjose opened this issue Sep 3, 2014 · 8 comments

Comments

@jasonsanjose
Copy link
Member

Extension manager and the package.json format https://github.com/adobe/brackets/wiki/Extension-package-format can't currently display locale specific metadata.

In order to meet specific translation needs per country, we need to display localized strings in the ExtensionManagerView for the following properties:

  • title - may not be applicable for trademarked names? e.g. Photoshop Express
  • description
  • keywords - for translated search

This is not to be confused with the current i18n property which describes which languages the extension has been localized in.

@jasonsanjose
Copy link
Member Author

A few different straw-man proposals:

  1. Add locale specific strings as sibling properties, e.g. "description.fr": "Fichier introuvable"
  2. Add locale as a top-level property in the package format: "fr": { "description": "Fichier introuvable" }
  3. By convention, check for nls/<locale>/package.json in extension (would require Extension Manager to do additional work for each extension to inspect zip contents)

Unfortunately, there's no precedent to follow in the NPM package format for translated metadata http://npmjs.org/doc/json.html.

@jasonsanjose
Copy link
Member Author

cc @peterflynn @ryanstewart

@jasonsanjose
Copy link
Member Author

Per standup, medium priority assigned to @bchintx

@bchintx
Copy link
Contributor

bchintx commented Sep 5, 2014

@jasonsanjose I've submitted PR #8987 which implements proposal #2 above.

bchintx added a commit that referenced this issue Sep 12, 2014
peterflynn added a commit that referenced this issue Sep 19, 2014
fix Issue #8953- "Localizing package metadata in Extension Manager"
@peterflynn
Copy link
Member

FBNC -- @bchintx do you want to verify with a 'real' extension before closing?

@redmunds redmunds added this to the Release 0.44 milestone Oct 2, 2014
@pthiess pthiess assigned jasonsanjose and unassigned bchintx Oct 8, 2014
@pthiess
Copy link
Contributor

pthiess commented Oct 8, 2014

FBNC @jasonsanjose @bchintx either one may verify, assigned to Jason as he filed the issue.

@jasonsanjose
Copy link
Member Author

Closed

@bchintx
Copy link
Contributor

bchintx commented Nov 6, 2014

Yup. Just confirmed this is Fixed with the Extract for Brackets (Preview) extension in both French and Japanese.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants