On last line of file, Duplicate clones text within line instead of adding new line

[peterflynn]

1. Open a file where the last line does not have a trailing CR (i.e. where the last numbered line is not blank)
2. Put the cursor on that line
3. Ctrl+D

Result: The text on the line is doubled (e.g. "abc;" -> "abc;abc;"). No new lines are added.

Expected: A new line is added cloning the line with the cursor on it, just like Ctrl+D on any earlier line in the file. This is how other editors work.

[peterflynn]

Note: Should add a unit test in EditorCommandHandlers-test whenever this bug is fixed.

[pthiess]

Reviewed- leave it open.

[glortho]

Oy, the codemirror.js code needs serious help. Frequently called anonymous functions with nested function definitions inside them, for starters. Double whammy. Is it fair game to modify this code or would we need to patch it through external overrides/scrubbing since it's third party?

[peterflynn]

@jedverity: We generally try to keep churn to CodeMirror low. We're also trying to move to a workflow where we submit changes to the main CodeMirror repo first, then pull them into Brackets.

However, for this particular bug the behavior in question is implemented in Brackets code: EditorCommandHandlers.js. So I don't think any CodeMirror changes should be necessary.

[glortho]

Understood, @peterflynn – just seeing where our boundaries are. I'll push the fix for this today (after going through the other contributor pre-reqs).

[peterflynn]

I already confirmed this when testing the pull request, so closing straight away