Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

[UX] Inactive panel gets dimmed in split view in release v1.0 #9785

Closed
MikeSpock opened this issue Nov 3, 2014 · 21 comments
Closed

[UX] Inactive panel gets dimmed in split view in release v1.0 #9785

MikeSpock opened this issue Nov 3, 2014 · 21 comments

Comments

@MikeSpock
Copy link

This isn't necessarily a bug, but definitely a usability issue. Split view is often used when you want to read one code and write the other. The inactive panel gets dimmed which makes the content hard to read.
This is especially bad when you want to use Brackets in a strongly lit enviroment.

@cheesypoof
Copy link
Contributor

Do you find the inactive pane content difficult to read for both light and dark themes?

I don't mind the dimming for light themes, but imho it is a little bit excessive for dark themes - perhaps opacity 0.8 instead of 0.7?

For reference, this change came in with #9560.

@MikeSpock
Copy link
Author

I'm using Monokai Dark Soda, a dark theme. I'm also working in an office with large windows, the dimming probably isn't a problem for those who are working in a workplace with less light. Also depends on the character of the monitor being used I guess.
By the way dimming does make it very clear, which panel has the focus, but still, if there would be an option to disable the dimming somewhere in the view menu, I'd not hesitate to do so.

If there would be an option in the menu, where users could set the opacity (or disable it completetly), that would work for all I guess. In my case, where I'm writing css on one side, and reading the html structure on the other, I would prefer no dimming at all.

@ArgTang
Copy link

ArgTang commented Nov 7, 2014

I agree with this. I use a dark theme, and it makes the out of focus panel hard to read. I like the idea, but not the current implementation.

Other ideas for this:
change backround color lighter or darker dep on current theme
Use the title bars with or without some kind of border around current pane

Edit: I switched to default dark theme and the effect works much better, maybe all theme authors have to update their designs? Maybe add tags to all extensions? would make easier to get witch extension is updated/tested for new version

@redmunds
Copy link
Contributor

redmunds commented Nov 7, 2014

@MikeSpock @ArgTang Themes are extensible, so the solution for now is to create your own Theme.

@peterflynn
Copy link
Member

I like the idea of having a preference for this. No other editor that I know of dims the text of inactive panes, so it may be pretty tough to get used to for some users.

@matthewoates
Copy link

This definitely should be an option. When I'm using the split view, that means I want to reference both files at the same time. This is difficult to do if it's very dark. It's obvious enough where the cursor is if you have the line highlight enabled.

+1

@MikeSpock
Copy link
Author

@redmunds the problem is the dimming itself - not the themes in my opinion. Obviously, dimming makes it more difficult to read text in any theme.
So what's the point in having split view if you disregard the contents of the inactive panel?
In case you do care about the contents of the inactive panel, dimming is not a good UI solution, and has a bad impact on productivity.

@sprintr
Copy link
Contributor

sprintr commented Nov 8, 2014

Forked @stowball's extension to restore opacity.

https://github.com/sprintr/brackets-restore-pane

@redmunds
Copy link
Contributor

redmunds commented Nov 8, 2014

@MikeSpock

So what's the point in having split view if you disregard the contents of the inactive panel?

FWIW, I personally would rather see that header change color than to dim the text. It's a design decision that was made and implemented as part of the default Brackets Themes, so I just wanted to let everyone know that it can be changed in a custom Theme.

@stowball
Copy link
Contributor

stowball commented Nov 9, 2014

You added this natively in b19cd4d? Ha. I agree with @MikeSpock, that it should be completely customisable (whether it happens at all, and the opacity that it sets), because this is a very personal choice

@ArgTang
Copy link

ArgTang commented Nov 9, 2014

If it is theme dependent it should only be applied when theme chooses to, not by default (imo)

As i said before I like the idea, but maybe find another way to focus current work space would be better.

@pthiess pthiess added this to the Release 1.1 milestone Nov 12, 2014
@pthiess
Copy link
Contributor

pthiess commented Nov 12, 2014

Simple and a lot of demand for this -- adding Release 1.1.

@JeffryBooher
Copy link
Contributor

@placegraphichere We want to roll back the opacity so that it's 100% all the time and let users install @stowball Zen Pane if they want to change to 70%. This means that we may need to tweak the styles for the inactive/active panel to show state in light and dark modes.

@JeffryBooher JeffryBooher changed the title Inactive panel gets dimmed in split view in release v1.0 [UX] Inactive panel gets dimmed in split view in release v1.0 Nov 12, 2014
@placegraphichere
Copy link

That sounds like a plan @JeffryBooher. As others mentioned, it would be best to do in conjunction with another visual affordance for the active/inactive panel.

@placegraphichere
Copy link

Here is a quick idea for switching panels. It should be compatible with themes, it is simply applying a quick (editable) animation to the active panel, and increased dimming the panel header text.

https://www.dropbox.com/s/k7u1mrayacvnmav/panel-switch-effect-01.mov?dl=0

@MikeSpock
Copy link
Author

@placegraphichere I like the idea of some smooth animation, but personally, I'd rather leave the panel content out of it. It is my personal opinion that the editor area which is in the very focus of the users' attention, should not flicker or change in looks when focus comes and goes.

Think about it: when switching panels, the user's eyes are already focused on the inactive panel. It seems redundant to have the panel make the click more clear that just happened. I think it would bring no value for the user. I'd find it a bit annoying if I wanted to select a text from the inactive panel, and while dragging the selection, the panel would flicker.

I'd work with the panel header text as you mentioned.

Code editors (webstorm, sublime, etc) solved this problem many times before, and somehow they all ended up using the panel header and maybe the panel frame's border color for indicating which panel is active. I think it would be an approach that would probably fit all, and we should go with that.

While my suggestion is more conservative - or as some would righteously say straight boring -, innovation which doesn't boost productivity should be best left out from a code editor.

What do you think?

Good job though, I like the animation in its own ;)

@dangoor dangoor modified the milestones: Release 1.2, Release 1.1 Dec 8, 2014
@le717
Copy link
Contributor

le717 commented Dec 19, 2014

Can this get fixed in 1.2? The new CEF in 1.1 has made the dimmed panel harder to read now (Windows 7 x64):

capture

I have a feeling this is somehow related to #9978 and/or #10083.

@peterflynn
Copy link
Member

We discussed this again in review today and here's what we want to do:

  • Editor content does not dim anymore when a pane is inactive. (If people want this effect, they can install the "Zen Panes" extension).
  • Pane header does still dim when pane is inactive.
  • If users report that this makes it too hard to tell the pane is focused (and the dimming/"Zen Panes" effect isn't a good enough fix), then we can revisit this and consider other treatments like a pane border or a brighter highlight in the pane header.

@prksingh prksingh self-assigned this Jan 13, 2015
@le717
Copy link
Contributor

le717 commented Jan 18, 2015

@peterflynn +1 I like that idea. I'd rather install an extension dim the pane rather than undim it.

@prksingh
Copy link
Contributor

@peterflynn Please review

@peterflynn
Copy link
Member

Closing -- this will be fixed in 1.2 per my comment above. Please let us know if you have any more feedback.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests