Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

No substitution, author term when the language changes. #9933

Closed
datamweb opened this issue Nov 14, 2014 · 7 comments
Closed

No substitution, author term when the language changes. #9933

datamweb opened this issue Nov 14, 2014 · 7 comments

Comments

@datamweb
Copy link
Contributor

Hello.
I am developing a extensions for Brackets And Farsi are also supported.
In this case, writing packegs file:

{
    "name": "p_parsa_dadashi.talesh",
    "title": "test",
    "description": "test description ",
    "homepage": "https://github.com/datamweb",
    "author": "pooya parsa dadashi",
    "version": "0.0.1",
    "license": "MIT",
    "engines": {
        "brackets": ">=0.24.0"
    },
    "i18n": [ "en","fa-ir"],
    "package-i18n": {
        "fa-ir": {
                "description": "توضیحات متن تست داتام وب",
                "title": "داتام وب افزونه",
                "author": "پویا پارسا داداشی"


        }
    }
}

.
The author will not be translated word.
Please be overcome.

@ingorichter
Copy link
Contributor

Sorry, but I don't know exactly what you mean. Are you asking if the author name can be translated too?

@datamweb
Copy link
Contributor Author

Thank you for your answer.
Please see the picture:
Image own
Image tow
Image 3

Did you notice?

@peterflynn
Copy link
Member

@datamweb Per #8987 (comment), we only allow localization for some fields in package.json. But we should probably expand that to allow author name to be localized too.

There's one wrinkle though: we currently 'normalize' the "author" field at validation time (see call to parsePersonString() in package-validator.js). We'll have to add code to also normalize any localized copies, in order for it to work correctly. Should be a relatively simple fix, though.

@nicolo-ribaudo
Copy link
Contributor

Is anyone working on this feature?

@peterflynn
Copy link
Member

@nicolo-ribaudo Not that I'm aware of -- feel free to work on a pull request if you're interested.

@datamweb
Copy link
Contributor Author

Hi @peterflynn.
@nicolo-ribaudo Opened a pull request for work on #9933.
please check.

@PlanetVaster
Copy link
Contributor

So should'nt the PR be pulled by now?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants