This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Updated getModeFromFileExtensions to let cfm and cfc files use the html editor #1138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ml editor. This will make any ColdFusion developers experience with brackets much much better.
ghost
assigned 
|
Looks good -- the highlighting is definitely imperfect, but it's clearly better than nothing. The biggest problem seems to be around CF tags that don't require a close tag -- you get a lot of close tags highlighted in red because CodeMirror thinks you skipped one. The HTML highlighter has a hardcoded list of the tags it expects to have no closing tag, and unfortunately it doesn't look like the list is configurable (see the top of xml.js). It would be an awesome contribution back to CodeMirror to add config options for that, and then you could leverage it to improve the CF highlighting. Interested? :-) This is certainly a reasonable start though. I'll merge it now. |
peterflynn
added a commit
that referenced
this pull request
Jun 26, 2012
Use generic HTML highlighting for ColdFusion .cfm and .cfc files
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make any ColdFusion developers experience with brackets much much better, currently if you open a cfm or cfc file it is unstyled. I know this project is not aimed supporting server side coding right now but I think this change (two lines of code added) is hopefully a no brainer.