Skip to content
This repository has been archived by the owner on Sep 6, 2021. It is now read-only.

Removed unnecessary prefixed property #12533

Merged
merged 1 commit into from
Aug 17, 2016
Merged

Removed unnecessary prefixed property #12533

merged 1 commit into from
Aug 17, 2016

Conversation

AllThingsSmitty
Copy link
Contributor

Changes made to the sample CSS files

@AllThingsSmitty
Copy link
Contributor Author

Contributor license agreement (CLA) has been signed. 👍🏼

@abose
Copy link
Contributor

abose commented Jun 29, 2016

Thanks @AllThingsSmitty .
Chrome 43+ supports animation. as we are on cef 2623[49] this chage is ok to go on win and mac.
unfortunately, Linux versions are still on 1547[29] and does not have full support of the above as specified in the CEF docs.
Was this tested on the linux builds?

@AllThingsSmitty
Copy link
Contributor Author

@abose I didn't get to testing it on Linux.

@marcelgerber
Copy link
Contributor

@abose Please keep in mind that these are only changes to the samples folder, which is never actually rendered inside our shell. So I think this change is fine, and we can totally expect our users to have adopted Chrome/Chromium 43+, Safari 9+ or Opera 30+. What do you think?

cc @ficristo

@ficristo
Copy link
Collaborator

These projects should be used to test all the available features of Brackets so we should be sure everything works inside the editor too.
So, while I agree that for Live Preview this PR is fine, I was thinking that some feature like Quick Edit may not work correctly?

@marcelgerber
Copy link
Contributor

Quick Edit and such features all run on the "JS-side" of Brackets and are thus doing the same on both the current and the Linux shell.

@ficristo
Copy link
Collaborator

@marcelgerber you know more than me the internals of Brackets so if it's features aren't affected this PR is fine.

@marcelgerber
Copy link
Contributor

Tested on Linux.
The animation doesn't work, but for another reason :) (Doesn't work on master as well)

I'll put up a fixup PR right away.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants