-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Conversation
It seems to me you have used the commit of the CodeMirror repository instead of using the adobe/CodeMirro2: I am unable to update the submodule. |
Ah, sorry, I forgot to push the updated version to our CodeMirror2 fork. I've done so now so you can try again. |
1bbf343
to
694476b
Compare
I have pulled the test fixes in, so you can have another look. |
Sorry but I don't think I'll have much time this or the next week to review this PR. So I see at least two options:
/cc @petetnt @MiguelCastillo @zaggino if they have more thoughts. |
Just so you know, we usually update to some commit of CodeMirror, not necessarily to a release version (in-between versions of CodeMirror are usually stable as well), so we can take in these recent fixes without problems. |
👍 for merge |
Ok, if you update against latest CodeMirror master and tests pass (or at least doesn't introduce new failures) then is fine by me. |
694476b
to
5c9d29f
Compare
See #12609.
cc @ficristo
I ran Unit, Integration and Extension tests without new failures.