This repository has been archived by the owner on Sep 6, 2021. It is now read-only.
Fix issue #1240 (Inline editor background width) #1264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
right when scrolling) - CodeMirror changed the way it props its width open such that lineSpace's width is no longer explicitly set to the max width of all the lines (lines wider than the viewport simply overflow it). We were checking this width to decide how wide inline editors must be. However, lineSpace's _content_ is still as wide as the max line (due to the pos of the new widthForcer div) so we can use lineSpace's scrollWidth and still get an accurate number.
ghost
assigned 
|
reviewing |
|
Yes, this fixes the issue captured in #1240, but I am seeing another issue:
Is that related to this fix, or should I log a new issue? |
|
@redmunds: yes, please log a new issue. Looks like that bug is also due to the CodeMirror merge this sprint, but it's unrelated to the fix here (in fact it repros even in a vanilla CodeMirror build from upstream, without any Brackets stuff at all). |
|
New issue #1267 logged for problem described above |
|
This fix looks good. |
redmunds
added a commit
that referenced
this pull request
Jul 17, 2012
Fix issue #1240 (Inline editor background width)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #1240 (Inline editor background doesn't extend all the way to right when scrolling)
CodeMirror changed the way it props its width open such that lineSpace's width is no longer explicitly set to the max width of all the lines (lines wider than the viewport simply overflow it). We were checking this width to decide how wide inline editors must be. However, lineSpace's content is still as wide as the max line (due to the pos of the new widthForcer div) so we can use lineSpace's scrollWidth and still get an accurate number.
See the bug for slightly more detail.